Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optional application/runtime/otlp input #1542

Merged
merged 25 commits into from
Oct 24, 2024

Conversation

k15r
Copy link
Contributor

@k15r k15r commented Oct 21, 2024

Description

Changes proposed in this pull request (what was done and why):

  • optional ApplicationInput in v1alpha1
  • optional RuntineImput for v1beta1
  • add optional OTLPInput

Criteria

  • Have a new OTLP input available on the dev release only
  • The new input can only be activated if there is an OTLP output
  • The new input can be used in parallel with runtime input
  • The new input can be used without runtime input, making the runtime input optional when used with OTLP output

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@k15r k15r requested a review from a team as a code owner October 21, 2024 11:39
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2024
@k15r k15r added kind/feature Categorizes issue or PR as related to a new feature. area/manager Manager or module changes area/logs LogPipeline do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cla: yes Indicates the PR's author has signed the CLA. area/manager Manager or module changes labels Oct 21, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 21, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2024
@k15r k15r changed the title feat: Optional application/runtime input feat: Optional application/runtime/otlp input Oct 22, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 22, 2024
@k15r k15r requested a review from a team as a code owner October 22, 2024 15:08
@k15r k15r removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2024
@TeodorSAP TeodorSAP added this to the 1.27.0 milestone Oct 23, 2024
@k15r k15r enabled auto-merge (squash) October 23, 2024 10:43
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 24, 2024
skhalash
skhalash previously approved these changes Oct 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 24, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 24, 2024
skhalash
skhalash previously approved these changes Oct 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 24, 2024
NHingerl
NHingerl previously approved these changes Oct 24, 2024
@k15r k15r dismissed stale reviews from NHingerl and skhalash via 79b311c October 24, 2024 12:30
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 24, 2024
@k15r k15r merged commit 30051c9 into kyma-project:main Oct 24, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants