Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Introduce FlatMetricFamily struct to flatten prometheus metric output #1538

Merged
merged 11 commits into from
Oct 22, 2024
Merged

chore: Introduce FlatMetricFamily struct to flatten prometheus metric output #1538

merged 11 commits into from
Oct 22, 2024

Conversation

jeffreylimnardy
Copy link
Contributor

Description

Changes proposed in this pull request (what was done and why):

  • Similar to chore: Improve metric matchers in e2e tests #1371, Prometheus output logs are deeply nested and unreadable. With this PR, a FlatMetricFamily struct is introduced
  • FlatMetricFamily makes output from self-monitor tests more readable and concise

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@jeffreylimnardy jeffreylimnardy requested a review from a team as a code owner October 21, 2024 07:32
@jeffreylimnardy jeffreylimnardy self-assigned this Oct 21, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 21, 2024
@jeffreylimnardy jeffreylimnardy added area/tests Writing/adding/Refactoring tests or checks kind/chore Categorizes issue or PR as related to a chore. and removed cla: yes Indicates the PR's author has signed the CLA. labels Oct 21, 2024
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 21, 2024
@jeffreylimnardy jeffreylimnardy enabled auto-merge (squash) October 21, 2024 07:32
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 21, 2024
@jeffreylimnardy jeffreylimnardy added this to the 1.27.0 milestone Oct 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 22, 2024
@jeffreylimnardy jeffreylimnardy merged commit 349eaa6 into kyma-project:main Oct 22, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

Labels
area/tests Writing/adding/Refactoring tests or checks cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreylimnardy @skhalash @kyma-bot