Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cover additional Secretref validation scenarios #1535

Merged
merged 28 commits into from
Oct 25, 2024

Conversation

TeodorSAP
Copy link
Member

@TeodorSAP TeodorSAP commented Oct 17, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Set name, namespace, and key fields of the SecretKeyRef type as required
  • Move secretref validation logic from API to secretref validator
  • This solved the "Secret deleted after ConfigurationGenerated set to True" scenario, as well
  • Add a new error message for missing fields in secret references
  • Rename ReferencedSecretMissing to ReferencedSecretInvalid to also include the newly added error

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@TeodorSAP TeodorSAP requested a review from a team as a code owner October 17, 2024 13:05
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2024
@TeodorSAP TeodorSAP added kind/bug Categorizes issue or PR as related to a bug. area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Oct 17, 2024
@TeodorSAP TeodorSAP added this to the 1.26.0 milestone Oct 17, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2024
@TeodorSAP TeodorSAP changed the title WIP: Secretref validation WIP: Cover additional Secretref validation scenarios Oct 18, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2024
@TeodorSAP TeodorSAP requested a review from a team as a code owner October 21, 2024 10:23
@a-thaler a-thaler modified the milestones: 1.26.0, 1.27.0 Oct 21, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 23, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 25, 2024
@TeodorSAP TeodorSAP merged commit a3d4f8b into kyma-project:main Oct 25, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secretRef without key does not fail the config generation
5 participants