generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cover additional Secretref validation scenarios #1535
Merged
TeodorSAP
merged 28 commits into
kyma-project:main
from
TeodorSAP:fix/secretref-validation
Oct 25, 2024
Merged
fix: Cover additional Secretref validation scenarios #1535
TeodorSAP
merged 28 commits into
kyma-project:main
from
TeodorSAP:fix/secretref-validation
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
cla: yes
Indicates the PR's author has signed the CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Oct 17, 2024
TeodorSAP
added
kind/bug
Categorizes issue or PR as related to a bug.
area/logs
LogPipeline
area/metrics
MetricPipeline
area/traces
TracePipeline
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
cla: yes
Indicates the PR's author has signed the CLA.
labels
Oct 17, 2024
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Oct 17, 2024
TeodorSAP
changed the title
WIP: Secretref validation
WIP: Cover additional Secretref validation scenarios
Oct 18, 2024
kyma-bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Oct 18, 2024
…include the 'missing fields' error + docs, manifests, and EP-validation changes
kyma-bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Oct 23, 2024
skhalash
reviewed
Oct 24, 2024
skhalash
reviewed
Oct 24, 2024
skhalash
reviewed
Oct 24, 2024
skhalash
reviewed
Oct 24, 2024
skhalash
reviewed
Oct 24, 2024
kyma-bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Oct 24, 2024
skhalash
approved these changes
Oct 25, 2024
grego952
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/logs
LogPipeline
area/metrics
MetricPipeline
area/traces
TracePipeline
cla: yes
Indicates the PR's author has signed the CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
Looks good to me!
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request (what was done and why):
name
,namespace
, andkey
fields of theSecretKeyRef
type as requiredReferencedSecretMissing
toReferencedSecretInvalid
to also include the newly added errorChanges refer to particular issues, PRs or documents:
Traceability
Related Issues
section.