Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert removal of drop kyma resource attributes #1471

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix: Revert removal of drop kyma resource attributes #1471

merged 2 commits into from
Sep 25, 2024

Conversation

rakesh-garimella
Copy link
Contributor

Description

Changes proposed in this pull request (what was done and why):

  • In the PR we removed filtering of kyma.source which had a side effect that kyma.source is now added into the resource attributes for the metrics. This behaviour is wrong and we need to drop the kyma.source attributes as its only used for resolving service name. Once the desired value is set we should remove these helper resource attributes

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@rakesh-garimella rakesh-garimella requested a review from a team as a code owner September 24, 2024 08:58
@rakesh-garimella rakesh-garimella added kind/bug Categorizes issue or PR as related to a bug. area/metrics MetricPipeline labels Sep 24, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Sep 24, 2024
@rakesh-garimella rakesh-garimella added this to the 1.25.0 milestone Sep 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 25, 2024
@kyma-bot kyma-bot merged commit aea637e into kyma-project:main Sep 25, 2024
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hisarbalik hisarbalik hisarbalik approved these changes

Assignees

@hisarbalik hisarbalik

Labels
area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rakesh-garimella @hisarbalik @kyma-bot