Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactor the config for telemetry manager after kymastats changes #1422

Merged
merged 15 commits into from
Sep 11, 2024
Merged

feat: Refactor the config for telemetry manager after kymastats changes #1422

merged 15 commits into from
Sep 11, 2024

Conversation

rakesh-garimella
Copy link
Contributor

@rakesh-garimella rakesh-garimella commented Sep 5, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • change the config as per kymastats receiver changes
  • Improve e2e tests

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@rakesh-garimella rakesh-garimella requested a review from a team as a code owner September 5, 2024 08:12
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2024
@rakesh-garimella rakesh-garimella added kind/feature Categorizes issue or PR as related to a new feature. area/manager Manager or module changes labels Sep 5, 2024
@rakesh-garimella rakesh-garimella added this to the 1.23.0 milestone Sep 10, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2024
@rakesh-garimella rakesh-garimella modified the milestones: 1.23.0, 1.24.0 Sep 10, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 11, 2024
@kyma-bot kyma-bot merged commit 01d1128 into kyma-project:main Sep 11, 2024
49 checks passed
@rakesh-garimella rakesh-garimella deleted the adappt-kymastatsrecv-config branch September 11, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hisarbalik hisarbalik hisarbalik approved these changes

Assignees

@hisarbalik hisarbalik

Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rakesh-garimella @hisarbalik @kyma-bot