Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move dashboard config maps from Kyma-system namespace #2028

Merged
merged 2 commits into from
Nov 15, 2024
Merged

chore: Move dashboard config maps from Kyma-system namespace #2028

merged 2 commits into from
Nov 15, 2024
+12 −43

Conversation

nesmabadr
Copy link
Contributor

@nesmabadr nesmabadr commented Nov 14, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Move dashboard config maps from Kyma-system namespace
  • Add the grafana_dashboard label as a standard patch instead of transformer

Related issue(s)
Resolves #1442

@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
@nesmabadr nesmabadr requested a review from a team as a code owner November 14, 2024 08:22
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 14, 2024
@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
@nesmabadr nesmabadr enabled auto-merge (squash) November 15, 2024 13:13
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 15, 2024
@nesmabadr nesmabadr merged commit 566bd9e into kyma-project:main Nov 15, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP approved these changes

Assignees

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move dashboard config maps out of kyma-system namespace
3 participants
@nesmabadr @Tomasz-Smelcerz-SAP @kyma-bot