Feat/module catalogue improvements rebase #1887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add explicit version attribute * Add test * Add test * Fix lint * Fix test * review fix * Fix compilation errors * Update api/v1beta2/moduletemplate_types.go Co-authored-by: Christoph Schwägerl <[email protected]> * ignore new fields in version comparison --------- Co-authored-by: Christoph Schwägerl <[email protected]>
* chore: Refactor NewCachedDescriptorProvider (kyma-project#1695) * remove parameter for NewCachedDescriptorProvider * fix dead link * adjust unit test coverage * fix flaky test * docs: Update KLM Local Test Setup Guide (kyma-project#1680) fix errors in local test setup documentation add version info * feat: Drop multiple ways to reference modules in Kyma CR (kyma-project#1672) * remove module reference by namespace/name * remove module reference by objectmeta name * remove module reference by FQDN * add initial test structure * add test cases for different module reference scenarios * fix tests * update documentation * address review comments * address more review comments * fix linting issues * rearrange imports * adjust documentation * chore: Configure different requeue intervals for Manifest reconciliation (kyma-project#1690) * Add different requeue intervals for Manifest reconciliation * Empty-Commit * code review comments * chore: Bump k8s deps (kyma-project#1703) * chore: Bump k8s deps * retrigger jobs * bump api folder as well --------- Co-authored-by: Nesma Badr <[email protected]> * fix: Manifest CR should update by moduletemplate generation changes (kyma-project#1702) * when moduletemplate generation updated, then manifest CR should also updated. * refactor regular_test.go --------- Co-authored-by: Benjamin Lindner <[email protected]> * fix bug due to modified ModuleName --------- Co-authored-by: Amritanshu Sikdar <[email protected]> Co-authored-by: Amritanshu Sikdar <[email protected]> Co-authored-by: Nesma Badr <[email protected]> Co-authored-by: Benjamin Lindner <[email protected]>
* add version to kyma.spec.modules list * add missing manifest update base on moduletemplate generation change. * remove parameter for NewCachedDescriptorProvider * fix dead link * adjust unit test coverage * fix flaky test * chore: Refactor NewCachedDescriptorProvider (kyma-project#1695) * remove parameter for NewCachedDescriptorProvider * fix dead link * adjust unit test coverage * fix flaky test * refactor FilterTemplate * add integration test * Update tests/integration/controller/kyma/kyma_module_channel_test.go Co-authored-by: Tomasz Smelcerz <[email protected]> * Update tests/integration/controller/kyma/kyma_module_version_test.go Co-authored-by: Tomasz Smelcerz <[email protected]> * fix existing test --------- Co-authored-by: Tomasz Smelcerz <[email protected]>
* update base branch to main * update base branch to main
* Implement changes in module catalog handling * review fix * review fix * review fix * remove test * fix lint * review fix
* remove kyma.spec.modules[n].version from api * Skip test * disable test * skip test * Skip test * Update api/v1beta2/kyma_types.go Co-authored-by: Christoph Schwägerl <[email protected]> --------- Co-authored-by: Christoph Schwägerl <[email protected]>
kyma-bot
added
cla: yes
|
Closed because these changes were merged already: #1892 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)