Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update with changes up to (including) d8f852600306aca92e6db329dea24e667551f0e8 #1881

Conversation

Tomasz-Smelcerz-SAP
Copy link
Member

Description

This is a preparation for merging the branch to main

This PR contains all the changes up to d8f8526

Changes proposed in this pull request:

  • ...
  • ...
  • ...

Related issue(s)

ruanxin and others added 8 commits July 19, 2024 10:24
…-project#1700)

* remove parameter for NewCachedDescriptorProvider

* fix dead link

* adjust unit test coverage

* fix flaky test
* Add explicit version attribute

* Add test

* Add test

* Fix lint

* Fix test

* review fix

* Fix compilation errors

* Update api/v1beta2/moduletemplate_types.go

Co-authored-by: Christoph Schwägerl <[email protected]>

* ignore new fields in version comparison

---------

Co-authored-by: Christoph Schwägerl <[email protected]>
* chore: Refactor NewCachedDescriptorProvider (kyma-project#1695)

* remove parameter for NewCachedDescriptorProvider

* fix dead link

* adjust unit test coverage

* fix flaky test

* docs: Update KLM Local Test Setup Guide (kyma-project#1680)

fix errors in local test setup documentation
add version info

* feat: Drop multiple ways to reference modules in Kyma CR (kyma-project#1672)

* remove module reference by namespace/name

* remove module reference by objectmeta name

* remove module reference by FQDN

* add initial test structure

* add test cases for different module reference scenarios

* fix tests

* update documentation

* address review comments

* address more review comments

* fix linting issues

* rearrange imports

* adjust documentation

* chore: Configure different requeue intervals for Manifest reconciliation (kyma-project#1690)

* Add different requeue intervals for Manifest reconciliation

* Empty-Commit

* code review comments

* chore: Bump k8s deps (kyma-project#1703)

* chore: Bump k8s deps

* retrigger jobs

* bump api folder as well

---------

Co-authored-by: Nesma Badr <[email protected]>

* fix: Manifest CR should update by moduletemplate generation changes (kyma-project#1702)

* when moduletemplate generation updated, then manifest CR should also updated.

* refactor regular_test.go

---------

Co-authored-by: Benjamin Lindner <[email protected]>

* fix bug due to modified ModuleName

---------

Co-authored-by: Amritanshu Sikdar <[email protected]>
Co-authored-by: Amritanshu Sikdar <[email protected]>
Co-authored-by: Nesma Badr <[email protected]>
Co-authored-by: Benjamin Lindner <[email protected]>
* add version to kyma.spec.modules list

* add missing manifest update base on moduletemplate generation change.

* remove parameter for NewCachedDescriptorProvider

* fix dead link

* adjust unit test coverage

* fix flaky test

* chore: Refactor NewCachedDescriptorProvider (kyma-project#1695)

* remove parameter for NewCachedDescriptorProvider

* fix dead link

* adjust unit test coverage

* fix flaky test

* refactor FilterTemplate

* add integration test

* Update tests/integration/controller/kyma/kyma_module_channel_test.go

Co-authored-by: Tomasz Smelcerz <[email protected]>

* Update tests/integration/controller/kyma/kyma_module_version_test.go

Co-authored-by: Tomasz Smelcerz <[email protected]>

* fix existing test

---------

Co-authored-by: Tomasz Smelcerz <[email protected]>
* update base branch to main

* update base branch to main
* Implement changes in module catalog handling

* review fix

* review fix

* review fix

* remove test

* fix lint

* review fix
* remove kyma.spec.modules[n].version from api

* Skip test

* disable test

* skip test

* Skip test

* Update api/v1beta2/kyma_types.go

Co-authored-by: Christoph Schwägerl <[email protected]>

---------

Co-authored-by: Christoph Schwägerl <[email protected]>
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 23, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP changed the title Changes up to (including) d8f852600306aca92e6db329dea24e667551f0e8 chore: update with changes up to (including) d8f852600306aca92e6db329dea24e667551f0e8 Sep 23, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP marked this pull request as draft September 23, 2024 07:32
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP changed the title chore: update with changes up to (including) d8f852600306aca92e6db329dea24e667551f0e8 chore: Update with changes up to (including) d8f852600306aca92e6db329dea24e667551f0e8 Sep 23, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP marked this pull request as ready for review September 23, 2024 23:38
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP changed the base branch from feat/module-catalogue-improvements to main September 24, 2024 09:52
@Tomasz-Smelcerz-SAP
Copy link
Member Author

Closing because this PR already contains all these changes: #1892

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants