Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Change watched-by label value from lifecycle-manager to kyma #1877

Merged
merged 1 commit into from
Sep 26, 2024
Merged

chore: Change watched-by label value from lifecycle-manager to kyma #1877

merged 1 commit into from
Sep 26, 2024

Conversation

amritanshusikdar
Copy link
Contributor

@amritanshusikdar amritanshusikdar commented Sep 19, 2024 •
edited by c-pius
Loading

Description

  • changes watched-by label value from lifecycle-manager to kyma

See Test PR to feature branch with this change for test verification (still stuffering from the pull_request_target problem): #1891

Related issue(s)
Resolves #1822

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2024
@amritanshusikdar amritanshusikdar changed the title drop watched-by module-manager,klm and add kyma feat: Drop watched-by module-manager,klm and add kyma Sep 19, 2024
@amritanshusikdar amritanshusikdar marked this pull request as ready for review September 19, 2024 09:20
@amritanshusikdar amritanshusikdar requested a review from a team as a code owner September 19, 2024 09:20
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2024
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 19, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2024
@amritanshusikdar amritanshusikdar force-pushed the watchedby-label-transparency branch 2 times, most recently from 3190335 to c9b7ff6 Compare September 24, 2024 11:38
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2024
@c-pius c-pius changed the title feat: Drop watched-by module-manager,klm and add kyma chore: Change watched-by label value from lifecycle-manager to kyma Sep 25, 2024
@c-pius c-pius mentioned this pull request Sep 25, 2024
Closed
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 25, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 26, 2024
@amritanshusikdar amritanshusikdar merged commit 1f2e30d into kyma-project:main Sep 26, 2024
34 of 35 checks passed
@amritanshusikdar amritanshusikdar deleted the watchedby-label-transparency branch September 26, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-pius c-pius c-pius approved these changes

Assignees

@c-pius c-pius

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make watched-by label more transparent
3 participants
@amritanshusikdar @kyma-bot @c-pius