Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove deprecated ControllerManagerConfig #1476

Merged
merged 2 commits into from
Apr 18, 2024
Merged

chore: Remove deprecated ControllerManagerConfig #1476

merged 2 commits into from
Apr 18, 2024

Conversation

nesmabadr
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Remove deprecated ControllerManagerConfig

Related issue(s)
Resolves #1375

@nesmabadr nesmabadr requested review from a team as code owners April 17, 2024 10:35
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2024
@nesmabadr nesmabadr force-pushed the remove_ControllerManagerConfig branch from b407c6c to 9825bae Compare April 17, 2024 10:42
c-pius
c-pius reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@c-pius c-pius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I am a bit confused about... Is my observation right that we partly prepared to use the ComponentConfig, but we never actually used it (we didn't load it in main)?

Apart from that, I think we also can delete the following:

@nesmabadr nesmabadr force-pushed the remove_ControllerManagerConfig branch from 9825bae to c7cb926 Compare April 17, 2024 15:08
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2024
@nesmabadr
Copy link
Contributor Author

nesmabadr commented Apr 17, 2024 •
edited
Loading

@c-pius Yes I couldn't find the ComponentConfig anywhere in the code itself, just the ones in the
kustomization

@nesmabadr nesmabadr requested a review from c-pius April 17, 2024 15:10
c-pius
c-pius previously approved these changes Apr 17, 2024
View reviewed changes
@kyma-bot kyma-bot added lgtm Looks good to me! and removed lgtm Looks good to me! labels Apr 17, 2024
@nesmabadr nesmabadr requested a review from c-pius April 18, 2024 07:32
mmitoraj
mmitoraj previously approved these changes Apr 18, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 18, 2024
@nesmabadr nesmabadr dismissed stale reviews from mmitoraj and c-pius via 8a592a3 April 18, 2024 07:39
@nesmabadr nesmabadr force-pushed the remove_ControllerManagerConfig branch from 168008c to 8a592a3 Compare April 18, 2024 07:39
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 18, 2024
@nesmabadr nesmabadr requested a review from mmitoraj April 18, 2024 07:40
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 18, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 18, 2024
@nesmabadr nesmabadr requested a review from mmitoraj April 18, 2024 07:41
@nesmabadr nesmabadr added the confirm/helm-update The author explicitly confirms that a Helm update is not needed or is taken care of label Apr 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 18, 2024
@kyma-bot kyma-bot merged commit fb6f058 into kyma-project:main Apr 18, 2024
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitoraj mmitoraj mmitoraj approved these changes

@c-pius c-pius c-pius approved these changes

Assignees

@c-pius c-pius

@mmitoraj mmitoraj

Labels
cla: yes Indicates the PR's author has signed the CLA. confirm/helm-update The author explicitly confirms that a Helm update is not needed or is taken care of lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated ControllerManagerConfig
4 participants
@nesmabadr @c-pius @mmitoraj @kyma-bot