Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Administrators added to parameters for SKR creation #977

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Aug 1, 2024

Description

Runtime CR requires administrators, so we need to provide these in provisioning parameters.

Changes proposed in this pull request:

Related issue(s)

#905
#791

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner August 1, 2024 12:11
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 1, 2024
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2024
@jaroslaw-pieszka jaroslaw-pieszka added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2024
MarekMichali
MarekMichali previously approved these changes Aug 1, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 1, 2024
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Looks good to me! labels Aug 1, 2024
lint fixes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 1, 2024
@kyma-bot kyma-bot merged commit 872fc3c into kyma-project:main Aug 1, 2024
30 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the fix-for-skr-tests branch August 1, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants