Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration - handle existing Runtime CR during retry #965

Merged
merged 2 commits into from
Jul 31, 2024
Merged

KIM Integration - handle existing Runtime CR during retry #965

merged 2 commits into from
Jul 31, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Jul 30, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Check if Runtime CR already exists - skipping creation
  • filling Runtime object structure in-place
  • fix for kyma name setting

Related issue(s)

#791
#905

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner July 30, 2024 11:37
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Jul 30, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 30, 2024
@jaroslaw-pieszka jaroslaw-pieszka added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed cla: yes Indicates the PR's author has signed the CLA. labels Jul 30, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2024
ralikio
ralikio previously approved these changes Jul 31, 2024
View reviewed changes
@kyma-bot kyma-bot added lgtm Looks good to me! and removed lgtm Looks good to me! labels Jul 31, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2024
@jaroslaw-pieszka
skip existing Runtime
f9b6757 
test case added

logging Kyma name, using utility function to calculate Runtime name

fix for kyma name

logging removed

logging added

renaming function

rebase complete
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 31, 2024
@kyma-bot kyma-bot merged commit 9f5526f into kyma-project:main Jul 31, 2024
31 of 32 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the fix-for-already-created-runtime branch July 31, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralikio ralikio ralikio approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@ralikio ralikio

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @ralikio @kyma-bot