Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels for Runtime CR - stage 1 of KIM integration #925

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Labels for Runtime CR - stage 1 of KIM integration #925

merged 8 commits into from
Jul 11, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Jul 11, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • setting labels
  • YAML library changed
  • extracting information from Kyma Template
  • printing YAML to stdout instead of log

Related issue(s)

#791

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner July 11, 2024 10:00
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Jul 11, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Jul 11, 2024
@jaroslaw-pieszka jaroslaw-pieszka added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed cla: yes Indicates the PR's author has signed the CLA. labels Jul 11, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 11, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 11, 2024
@jaroslaw-pieszka jaroslaw-pieszka force-pushed the annotations-and-labels-for-runtime-cr branch from 50654f5 to ae11cf6 Compare July 11, 2024 10:46
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2024
@jaroslaw-pieszka
labels initialize
26606f4 
yaml library changed

more labels set properly

TODOs added

commas corrected

TODOs removed

go imports
@jaroslaw-pieszka jaroslaw-pieszka force-pushed the annotations-and-labels-for-runtime-cr branch from 626b92d to 26606f4 Compare July 11, 2024 11:05
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 11, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 11, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 11, 2024
@kyma-bot kyma-bot merged commit 509e6aa into kyma-project:main Jul 11, 2024
22 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the annotations-and-labels-for-runtime-cr branch August 7, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrmiskiewicz piotrmiskiewicz piotrmiskiewicz approved these changes

Assignees

@piotrmiskiewicz piotrmiskiewicz

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @piotrmiskiewicz @kyma-bot