Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Kyma Infrastructure Manager - Phase 0 #918

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Using Kyma Infrastructure Manager - Phase 0 #918

merged 4 commits into from
Jul 11, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Jul 9, 2024 •
edited
Loading

Description

In phase 1 we use still provisioner to provision Kyma but we will prepare object to create Runtime CR in the next stage.
In this PR we introduce initial changes allowing to work on phase 1 and subsequent ones in parallel.

Changes proposed in this pull request:

  • Configuration dedicated for KIM integration process
  • Step creating RuntimeID if it is not provided by provisioner
  • Barebones of step creating object for Runtime CR - at the beginning we will log yaml only, then we switch (on feature flag) to actual resource creation

Related issue(s)

#791

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner July 9, 2024 09:00
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Jul 9, 2024
@jaroslaw-pieszka jaroslaw-pieszka added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jul 9, 2024
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Jul 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 9, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jul 9, 2024
@jaroslaw-pieszka jaroslaw-pieszka changed the title Using Kyma Infrastructure Manager for provisioning Using Kyma Infrastructure Manager - configuring client Jul 9, 2024
@jaroslaw-pieszka jaroslaw-pieszka changed the title Using Kyma Infrastructure Manager - configuring client Using Kyma Infrastructure Manager - Phase 1 Jul 10, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2024
@jaroslaw-pieszka
initial configuration
e401e52 
imports and stuff

naming changed and barebones

dryRun corrected

returning errors

moved to step, simple unit tests

step for generating RuntimeID

two steps created but no tests yet

just config instead of client

refactor finished

GenerateRuntimeID tests pass

minimal tests

logging yaml in dryRun mode
@jaroslaw-pieszka jaroslaw-pieszka changed the title Using Kyma Infrastructure Manager - Phase 1 Using Kyma Infrastructure Manager - Phase 0 Jul 11, 2024
@jaroslaw-pieszka jaroslaw-pieszka removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 11, 2024
@kyma-bot kyma-bot merged commit a71867d into kyma-project:main Jul 11, 2024
25 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the kyma-infrastructure-manager branch July 11, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrmiskiewicz piotrmiskiewicz piotrmiskiewicz approved these changes

Assignees

@piotrmiskiewicz piotrmiskiewicz

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @piotrmiskiewicz @kyma-bot