Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing CIS access for subaccount-sync #666

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Fixing CIS access for subaccount-sync #666

merged 9 commits into from
Apr 17, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Apr 15, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • metrics port configuration corrected

Related issue(s)

#60

@jaroslaw-pieszka jaroslaw-pieszka added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature labels Apr 15, 2024
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Apr 15, 2024
@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner April 15, 2024 07:28
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Apr 15, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2024
ukff
ukff previously approved these changes Apr 17, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 17, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 17, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 17, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 17, 2024
@jaroslaw-pieszka jaroslaw-pieszka added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature labels Apr 17, 2024
@kyma-bot
Copy link
Contributor

@jaroslaw-pieszka: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 17, 2024
@jaroslaw-pieszka jaroslaw-pieszka merged commit 8131122 into kyma-project:main Apr 17, 2024
29 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the subaccount-sync-fixing-oauth branch April 17, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukff ukff ukff approved these changes

@MarekMichali MarekMichali MarekMichali approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@MarekMichali MarekMichali

@ukff ukff

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaroslaw-pieszka @kyma-bot @MarekMichali @ukff