Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB layer for betaEnabled #517

Closed
wants to merge 3 commits into from
Closed

DB layer for betaEnabled #517

wants to merge 3 commits into from

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Mar 6, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Interface with queries for subaccount_states
  • Postgres implementation
  • In-memory implementation

Related issue(s)

#516

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Mar 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Mar 6, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 6, 2024
@jaroslaw-pieszka jaroslaw-pieszka added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 6, 2024
@jaroslaw-pieszka jaroslaw-pieszka changed the title DB layer for beta enabled DB layer for betaEnabled Mar 6, 2024
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
@jaroslaw-pieszka
initial commit but compilation fails
b6114c2 
correct db setup

creation

upsert redefined

unit tests for db

passing unit test for db layer

all functions covered

in-memory covered
@jaroslaw-pieszka jaroslaw-pieszka removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
@jaroslaw-pieszka jaroslaw-pieszka marked this pull request as ready for review March 6, 2024 14:15
@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner March 6, 2024 14:15
@jaroslaw-pieszka jaroslaw-pieszka deleted the db-layer-for-beta-enabled branch March 6, 2024 15:26
@jaroslaw-pieszka jaroslaw-pieszka restored the db-layer-for-beta-enabled branch March 6, 2024 15:31
@jaroslaw-pieszka jaroslaw-pieszka deleted the db-layer-for-beta-enabled branch March 6, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaroslaw-pieszka @kyma-bot