Logging Worker Execution Times Only if Limit Exceeded #1604
Conversation
Removing execution time for given worker in removeTimeIfInWarnMargin function to track only workers that exceed allowed margin time. Added additional workerLastKeys map to keep worker keys for logging in worker summary go routine.
kyma-bot
added
do-not-merge/work-in-progress
|
Add one of following labels |
kyma-bot
added
the
size/M
kyma-bot
removed
the
do-not-merge/work-in-progress
|
|
||
| processingTime := time.Since(processingStart) | ||
|
|
||
| if processingTime > q.warnAfterTime { |
There was a problem hiding this comment.
Will we log here information when the worker is idle?
In case there is nothing in the queue to process for a long time so the last execution time (in q.workerExecutionTimes[workerNameId] is very old.
There was a problem hiding this comment.
In the case the time from workerExecutionTimes is removed in https://github.com/kyma-project/kyma-environment-broker/pull/1604/files#diff-e94ea6ee51e7a52f24c56388c5828851ee956a6cb5d30cf83a6a82cef2f7784cR119 before a chance to log it hence not producing idle logs.
There was a problem hiding this comment.
Iddle logs were produced in the healthcheck go routine.
Remove times only one time in the code.
Removing execution time for given worker in removeTimeIfInWarnMargin function to track only workers that exceed allowed margin time. Added additional workerLastKeys map to keep worker keys for logging in worker summary go routine.
Description
Changes proposed in this pull request:
Related issue(s)
#1473