Add more check for PR's merged during release #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
|
Add one of following labels |
kyma-bot
added
the
size/S
|
/kind enhancement |
kyma-bot
added
the
kind/enhancement
kyma-bot
removed
the
do-not-merge/work-in-progress
MarekMichali
commented
Nov 13, 2024
| @@ -268,6 +268,16 @@ jobs: | |||
| echo "Step skipped" | |||
| fi | |||
|
|
|||
| - name: Check if any PR have been merged before merging the bump PR | |||
| run: | | |||
| COMMIT_SHA=$(gh api repos/${{ env.KYMA_ENVIRONMENT_BROKER_REPO }}/commits -q '.[1].sha') | |||
There was a problem hiding this comment.
this check the commit before the PR bump
ralikio
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checks if a PR has been merged after the first PR merge check and before the bumps are merged.
This checks also if a PR has been merged after the second PR merge check and before the draft release and tag are created.
This covers the corner case scenario where there is about a ~1 s window in the whole release where we could merge a PR and not detect it when needed.
Related issue(s)