Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics for bindings #1401

Merged
merged 24 commits into from
Nov 13, 2024
Merged

Metrics for bindings #1401

merged 24 commits into from
Nov 13, 2024

Conversation

piotrmiskiewicz
Copy link
Member

@piotrmiskiewicz piotrmiskiewicz commented Oct 31, 2024 •
edited
Loading

Description

Changes proposed in this pull request:
Provides the following metrics:

  • kcp_keb_v2_bind_duration_millisecond
  • kcp_keb_v2_unbind_duration_millisecond
  • kcp_keb_v2_binding_created_total
  • kcp_keb_v2_minutes_since_earliest_binding_expiration

Related issue(s)
Related: #1359

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Oct 31, 2024
@piotrmiskiewicz
Copy link
Member Author

/test all

@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot
Copy link
Contributor

@piotrmiskiewicz: No presubmit jobs available for kyma-project/kyma-environment-broker@main

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 31, 2024
@piotrmiskiewicz piotrmiskiewicz added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 5, 2024
@piotrmiskiewicz piotrmiskiewicz marked this pull request as ready for review November 5, 2024 12:46
@piotrmiskiewicz piotrmiskiewicz requested a review from a team as a code owner November 5, 2024 12:46
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) November 5, 2024 12:46
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 13, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 13, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 13, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 13, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@kyma-gopher-bot kyma-gopher-bot merged commit 62a0544 into kyma-project:main Nov 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@piotrmiskiewicz piotrmiskiewicz

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piotrmiskiewicz @kyma-bot @jaroslaw-pieszka @kyma-gopher-bot