Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration - removal of the managedFields key in metadata #1129

Merged
merged 2 commits into from
Sep 12, 2024
Merged

KIM Integration - removal of the managedFields key in metadata #1129

merged 2 commits into from
Sep 12, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Sep 12, 2024 •
edited
Loading

Description

Setting value to nil did not prevent serialization.

Changes proposed in this pull request:

  • key managedFields removed from metadata

Related issue(s)

#791
#905
#1105

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner September 12, 2024 11:56
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Sep 12, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 12, 2024
@jaroslaw-pieszka jaroslaw-pieszka added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed cla: yes Indicates the PR's author has signed the CLA. labels Sep 12, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Sep 12, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 12, 2024
@kyma-bot kyma-bot merged commit 453cba5 into kyma-project:main Sep 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukff ukff ukff approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@ukff ukff

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @ukff @kyma-bot