Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration - managed by provisioner label not set for KIM only #1040

Merged
merged 4 commits into from
Aug 14, 2024
Merged

KIM Integration - managed by provisioner label not set for KIM only #1040

merged 4 commits into from
Aug 14, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Setting label to false when KIM only driven plan, regardless of viewOnly setting
  • volumeSize converted properly

Related issue(s)

#791
#905

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner August 14, 2024 13:47
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Aug 14, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Aug 14, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Aug 14, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 14, 2024
@kyma-bot kyma-bot merged commit 9034778 into kyma-project:main Aug 14, 2024
26 checks passed
@jaroslaw-pieszka jaroslaw-pieszka removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. lgtm Looks good to me! cla: yes Indicates the PR's author has signed the CLA. labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrmiskiewicz piotrmiskiewicz piotrmiskiewicz approved these changes

Assignees

@piotrmiskiewicz piotrmiskiewicz

@jaroslaw-pieszka jaroslaw-pieszka

Labels
kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @piotrmiskiewicz @kyma-bot