Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[betaEnabled] Extract operations on table subaccount_states as separate PR #516

Open
2 tasks done
jaroslaw-pieszka opened this issue Mar 6, 2024 · 0 comments
Open
2 tasks done
Assignees

Comments

@jaroslaw-pieszka
Copy link
Contributor

jaroslaw-pieszka commented Mar 6, 2024

PR #460 introduces table subaccount_states designed to cache CIS managed state of betaEnabled and usedForProduction.

To manage the change in the more controlled way extract relevant changes from PR #460 and create separate one.

NOTE: Bear in mind that by design there is neither Insert nor Update operation.
There is Upsert

  • add unit tests
  • consider reimplementation of Upsert to change strategy (first update then insert) - see TODO in the code - we can assume that DB and driver support rowsAffected so if update return no rowsAffected we should insert row.
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Mar 6, 2024
This was referenced Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant