minimal tests

internal/process/provisioning/create_runtime_resource_step.go

@@ -41,14 +41,14 @@ func (s *CreateRuntimeResourceStep) Run(operation internal.Operation, log logrus
 	}
 
 	if !s.kimConfig.IsEnabledForPlan(broker.PlanNamesMapping[operation.ProvisioningParameters.PlanID]) {
-		log.Infof("KIM is disabled for plan %s, skipping", broker.PlanNamesMapping[operation.ProvisioningParameters.PlanID])
+		log.Infof("KIM is not enabled for plan %s, skipping", broker.PlanNamesMapping[operation.ProvisioningParameters.PlanID])
 	}
 
 	log.Info("Runtime CR creation process finished successfully")
 	return operation, 0, nil
 }
 
-//TODO remember labels and annotations
+//TODO remember - labels and annotations
 
 func (s *CreateRuntimeResourceStep) createRuntimeResourceObject(operation internal.Operation) (imv1.Runtime, error) {
 	runtime := imv1.Runtime{}

internal/process/provisioning/create_runtime_resource_step_test.go

@@ -0,0 +1,45 @@
+package provisioning
+
+import (
+	"github.com/kyma-project/kyma-environment-broker/internal/fixture"
+	"github.com/kyma-project/kyma-environment-broker/internal/kim"
+	"testing"
+
+	"github.com/kyma-project/kyma-environment-broker/internal/storage"
+	"github.com/sirupsen/logrus"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestCreateRuntimeResourceStep_HappyPath_YamlOnly(t *testing.T) {
+	// given
+	log := logrus.New()
+	memoryStorage := storage.NewMemoryStorage()
+
+	preOperation := fixture.FixProvisioningOperation(operationID, instanceID)
+	err := memoryStorage.Operations().InsertOperation(preOperation)
+	assert.NoError(t, err)
+
+	err = memoryStorage.Instances().Insert(fixInstance())
+	assert.NoError(t, err)
+
+	kimConfig := kim.Config{
+		Enabled:  true,
+		Plans:    []string{"preview"},
+		ViewOnly: false,
+		DryRun:   true,
+	}
+	step := NewCreateRuntimeResourceStep(memoryStorage.Operations(), memoryStorage.RuntimeStates(), memoryStorage.Instances(), kimConfig)
+
+	// when
+	entry := log.WithFields(logrus.Fields{"step": "TEST"})
+	_, repeat, err := step.Run(preOperation, entry)
+
+	// then
+	assert.NoError(t, err)
+	assert.Zero(t, repeat)
+
+	_, err = memoryStorage.Instances().GetByID(preOperation.InstanceID)
+	assert.NoError(t, err)
+
+	//assert.YAMLEq(t, expectedKymaTemplate, op.KymaTemplate)
+}

internal/process/provisioning/generate_runtime_id_step_test.go

@@ -1,7 +1,7 @@
 package provisioning
 
 import (
-	"github.com/kyma-project/kyma-environment-broker/internal/broker"
+	"github.com/kyma-project/kyma-environment-broker/internal/fixture"
 	"testing"
 
 	"github.com/sirupsen/logrus"
@@ -19,8 +19,7 @@ func TestNewGenerateRuntimeIDStep_LeaveRuntimeIDIfNotEmpty(t *testing.T) {
 	err := memoryStorage.Instances().Insert(instance)
 	assert.NoError(t, err)
 
-	operation := fixOperationCreateRuntime(t, broker.GCPPlanID, "europe-west3")
-	operation.ShootDomain = "kyma.org"
+	operation := fixture.FixProvisioningOperation(operationID, instanceID)
 	operation.RuntimeID = instance.RuntimeID
 
 	err = memoryStorage.Operations().InsertOperation(operation)
@@ -47,8 +46,7 @@ func TestNewGenerateRuntimeIDStep_LeaveCreateRuntimeIDIfEmpty(t *testing.T) {
 	log := logrus.New()
 	memoryStorage := storage.NewMemoryStorage()
 
-	operation := fixOperationCreateRuntime(t, broker.GCPPlanID, "europe-west3")
-	operation.ShootDomain = "kyma.org"
+	operation := fixture.FixProvisioningOperation(operationID, instanceID)
 	operation.RuntimeID = ""
 	err := memoryStorage.Operations().InsertOperation(operation)
 	assert.NoError(t, err)