Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor configs #348

Merged
merged 6 commits into from
Jan 27, 2025
Merged

chore: refactor configs #348

merged 6 commits into from
Jan 27, 2025

Conversation

mfaizanse
Copy link
Member

Description

Changes proposed in this pull request:

  • Remove support for .env.test file.

Related issue(s)

@mfaizanse mfaizanse added evaluation requested A PR with this label will trigger the validation workflow. run-integration-test labels Jan 22, 2025
@mfaizanse mfaizanse requested a review from a team as a code owner January 22, 2025 11:38
@mfaizanse mfaizanse requested a review from muralov January 22, 2025 11:38
Copy link

Note(s) for PR Auther:

  • The integration test will be skipped for the PR. You can trigger it manually after adding the label: run-integration-test.
  • The evaluation test will be skipped for the PR. You can trigger it manually after adding the label: evaluation requested.
  • If any changes are made to the evaluation tests data, make sure that the integration tests are working as expected.
  • If any changes are made to how to run the unit tests, make sure to update the steps for unit-tests in the create-release.yml workflow as well.

Note(s) for PR Reviewer(s):

  • Make sure that the integration and evaluation tests are working as expected.

@kyma-bot kyma-bot added size/XL and removed size/M labels Jan 22, 2025
@mfaizanse mfaizanse linked an issue Jan 22, 2025 that may be closed by this pull request
@kyma-bot kyma-bot removed the lgtm label Jan 27, 2025
@mfaizanse mfaizanse removed evaluation requested A PR with this label will trigger the validation workflow. run-integration-test labels Jan 27, 2025
proxy_client: BaseProxyClient | None = None


def get_gen_ai_proxy_client() -> BaseProxyClient:
Copy link
Collaborator

@muralov muralov Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: you can use lru_cache if you want to avoid global variable. You can search other places of companion that is used.

@lru_cache(maxsize=1)
def init_proxy_client() -> BaseProxyClient:
    """Initialize the proxy client for the GenAI Hub only once."""
    return get_proxy_client("gen-ai-hub")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a comment, you don't have to do it now.

We need to share the model logic from a shared package. There is an issue already we'll do it later.

@kyma-bot kyma-bot added the lgtm label Jan 27, 2025
@kyma-bot kyma-bot merged commit 4f4e618 into kyma-project:main Jan 27, 2025
14 checks passed
@mfaizanse mfaizanse deleted the kc-343-1 branch January 27, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Secret Management and Test Configuration Handling
4 participants