Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change certificate key size to 4096 bits #984

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Change certificate key size to 4096 bits #984

merged 4 commits into from
Aug 22, 2024

Conversation

werdes72
Copy link
Collaborator

@werdes72 werdes72 commented Aug 20, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Change certificate key size
  • Fix typo

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues
#969

Info
https://istio.io/latest/docs/ops/configuration/traffic-management/manage-mesh-certificates/

Can be tested with:

kubectl get secrets -n istio-system istio-ca-secret --template='{{ range $key, $value := .data }}{{ printf "%s: %s\n" $key ($value | base64decode) }}{{ end }}'

@werdes72 werdes72 requested a review from a team as a code owner August 20, 2024 08:24
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 20, 2024
@werdes72 werdes72 requested a review from a team as a code owner August 21, 2024 06:45
Ressetkk
Ressetkk previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@Ressetkk Ressetkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 21, 2024
videlov
videlov previously approved these changes Aug 22, 2024
View reviewed changes
@videlov
Copy link
Collaborator

videlov commented Aug 22, 2024

@werdes72 @nataliasitko Release notes?

@werdes72 werdes72 dismissed stale reviews from videlov and Ressetkk via 0b2156f August 22, 2024 09:15
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 22, 2024
@videlov videlov self-requested a review August 22, 2024 10:20
videlov
videlov previously approved these changes Aug 22, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 22, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 22, 2024
@werdes72 werdes72 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 22, 2024
@kyma-bot kyma-bot merged commit 1bb2592 into kyma-project:main Aug 22, 2024
24 checks passed
werdes72 added a commit to werdes72/istio that referenced this pull request Aug 22, 2024
@werdes72 @nataliasitko
Change certificate key size to 4096 bits (kyma-project#984)
0366398 
* Change certificate key size to 4096 bits

* Add docs

* Add RN

* Update docs/release-notes/1.8.3.md

Co-authored-by: Natalia Sitko <[email protected]>

---------

Co-authored-by: Natalia Sitko <[email protected]>
@werdes72 werdes72 mentioned this pull request Aug 22, 2024
Merged
1 task
kyma-bot pushed a commit that referenced this pull request Aug 22, 2024
@werdes72 @nataliasitko
Change certificate key size to 4096 bits (#984) (#987)
5d454d6 
* Change certificate key size to 4096 bits

* Add docs

* Add RN

* Update docs/release-notes/1.8.3.md



---------

Co-authored-by: Natalia Sitko <[email protected]>
@werdes72 werdes72 deleted the cert-4096 branch August 23, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliasitko nataliasitko nataliasitko approved these changes

@Ressetkk Ressetkk Ressetkk left review comments

@videlov videlov videlov left review comments

Assignees

@videlov videlov

@Ressetkk Ressetkk

@nataliasitko nataliasitko

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@werdes72 @videlov @Ressetkk @nataliasitko @kyma-bot