Skip to content

Commit

Permalink
Revert changes due to logging update
Browse files Browse the repository at this point in the history
  • Loading branch information
triffer committed Jun 13, 2024
1 parent 470cff6 commit 0c87e58
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 11 deletions.
11 changes: 6 additions & 5 deletions cmd/istio-install/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ func main() {
iopFileNames := []string{os.Args[1]}

consoleLogger := istioclient.CreateIstioLibraryLogger()

if err := istioclient.ConfigureIstioLogScopes(); err != nil {
consoleLogger.LogAndError("Failed to configure Istio log: ", err)
os.Exit(1)
}

printer := istio.NewPrinterForWriter(os.Stdout)

rc, err := kube.DefaultRestConfig("", "", func(config *rest.Config) {
Expand All @@ -40,11 +46,6 @@ func main() {
os.Exit(1)
}

if err := istioclient.ConfigureIstioLogScopes(); err != nil {
consoleLogger.LogAndError("Failed to configure Istio log: ", err)
os.Exit(1)
}

// We don't want to verify after installation, because it is unreliable
installArgs := &istio.InstallArgs{ReadinessTimeout: 150 * time.Second, SkipConfirmation: true, Verify: false, InFilenames: iopFileNames}

Expand Down
8 changes: 2 additions & 6 deletions tests/integration/steps/istio.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,8 @@ func IstioComponentHasResourcesSetToCpuAndMemory(ctx context.Context, component,
}

func UninstallIstio(ctx context.Context) error {
c, err := istio.NewIstioClient()
if err != nil {
return err
}

return c.Uninstall(ctx)
istioClient := istio.NewIstioClient()
return istioClient.Uninstall(ctx)
}

func getResourcesForIstioComponent(k8sClient client.Client, component, resourceType string) (*resourceStruct, error) {
Expand Down

0 comments on commit 0c87e58

Please sign in to comment.