KIM - Fix of the problem with removing exiting shoots using client.Update function to change shoot workers #650
+54
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
kyma-bot
added
size/S
kyma-bot
added
size/M
koala7659
changed the title
Disper
reviewed
Feb 10, 2025
| copyShoot := s.shoot.DeepCopy() | ||
| copyShoot.Spec.Provider.Workers = updatedShoot.Spec.Provider.Workers | ||
|
|
||
| err = m.ShootClient.Update(ctx, copyShoot, |
There was a problem hiding this comment.
could you just shortly describe in a comment why this second update is needed?
Also, do you think it would be worth to extract this to another method such as `handleWorkerPoolsUpdate() to clearly distinguish which code is responsible for this exceptional logic?
There was a problem hiding this comment.
I'm wondering if it would make sense to check if shootWorkers differ from the ones specified in runtimeCR and doing additional update only if they do.
What do you think?
There was a problem hiding this comment.
There is the whole workers comparison and matching logic inside converter, this idea would imply this code would have to be duplicated. I can try to come up with something
… shoot workers, restore old convert code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for the bug for scenario when user wanted to remove some workers initially created with the shoot.
Affected scenarios:
Proposed two steps operation as a fix:
client.Updateusing existing shoot as a baseclient.Patchas in the previous approachRelated issue(s)
Additional worker node pools are not removed from shoot