Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint fix: dupword #67

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Lint fix: dupword #67

merged 2 commits into from
Jan 29, 2024

Conversation

the1bit
Copy link
Contributor

@the1bit the1bit commented Jan 26, 2024

Description

Changes proposed in this pull request:

  • Lint fix: dupword

Related issue(s)

.golangci.yaml related PR: kyma-project/eventing-tools#58

@the1bit the1bit added area/cli Related to all activities around CLI do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 26, 2024
@the1bit the1bit requested a review from a team as a code owner January 26, 2024 15:06
@the1bit the1bit requested a review from muralov January 26, 2024 15:06
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 26, 2024
@the1bit the1bit added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jan 26, 2024
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Jan 26, 2024
@the1bit the1bit removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2024
@@ -16,4 +16,4 @@ jobs:
uses: kyma-project/eventing-tools/.github/workflows/lint-go-reusable.yml@main
with:
go-version: '1.21'
lint-config-uri: https://raw.githubusercontent.com/kyma-project/eventing-tools/b740019d37e5b69c1a1383c71bb5fb5a44c6534e/config/lint/.golangci.yaml
lint-config-uri: https://raw.githubusercontent.com/kyma-project/eventing-tools/ca5d5cc431d9fb5cd12e7ef4c6c82331f203c630/config/lint/.golangci.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a description to the PR what changes this will entail? Or point to the corresponding PR?

Copy link
Contributor Author

@the1bit the1bit Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. :-)

I've updated the PR description with this: .golangci.yaml related PR: kyma-project/eventing-tools#58

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 29, 2024
@kyma-bot kyma-bot merged commit 33a213c into kyma-project:main Jan 29, 2024
7 checks passed
@the1bit the1bit deleted the go-lint--dupword branch January 29, 2024 10:42
mfaizanse pushed a commit to mfaizanse/eventing-publisher-proxy that referenced this pull request Sep 3, 2024
* dupword - Fix

* Lint config
the1bit added a commit that referenced this pull request Sep 3, 2024
* dupword - Fix

* Lint config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants