generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove subscription v1alpha1 tests #530
Merged
kyma-bot
merged 1 commit into
kyma-project:main
from
marcobebway:remove-subscription-v1alpha1-tests
Mar 14, 2024
Merged
chore: remove subscription v1alpha1 tests #530
kyma-bot
merged 1 commit into
kyma-project:main
from
marcobebway:remove-subscription-v1alpha1-tests
Mar 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/hold |
kyma-bot
added
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Mar 13, 2024
mfaizanse
previously approved these changes
Mar 13, 2024
marcobebway
force-pushed
the
remove-subscription-v1alpha1-tests
branch
from
March 14, 2024 08:44
54f3bf3
to
daf02c4
Compare
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
lgtm
Looks good to me!
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Mar 14, 2024
marcobebway
changed the title
chore: remore tests for subscription v1alpha1 tests
chore: remove tests for subscription v1alpha1
Mar 14, 2024
marcobebway
changed the title
chore: remove tests for subscription v1alpha1
chore: remove subscription v1alpha1 tests
Mar 14, 2024
mfaizanse
approved these changes
Mar 14, 2024
marcobebway
commented
Mar 14, 2024
} | ||
} | ||
return nil | ||
return te.WaitForSubscriptions(context.TODO(), fixtures.V1Alpha2SubscriptionsToTest()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug fix.
/hold cancel |
kyma-bot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove subscription v1alpha1 tests.
Related issue(s)