Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove subscription v1alpha1 tests #530

Merged

Conversation

marcobebway
Copy link
Contributor

@marcobebway marcobebway commented Mar 13, 2024

Description

Remove subscription v1alpha1 tests.

Related issue(s)

@marcobebway marcobebway requested a review from a team as a code owner March 13, 2024 14:23
@marcobebway marcobebway requested a review from k15r March 13, 2024 14:23
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 13, 2024
@marcobebway
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2024
mfaizanse
mfaizanse previously approved these changes Mar 13, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 13, 2024
@marcobebway marcobebway force-pushed the remove-subscription-v1alpha1-tests branch from 54f3bf3 to daf02c4 Compare March 14, 2024 08:44
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2024
@marcobebway marcobebway changed the title chore: remore tests for subscription v1alpha1 tests chore: remove tests for subscription v1alpha1 Mar 14, 2024
@marcobebway marcobebway changed the title chore: remove tests for subscription v1alpha1 chore: remove subscription v1alpha1 tests Mar 14, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 14, 2024
}
}
return nil
return te.WaitForSubscriptions(context.TODO(), fixtures.V1Alpha2SubscriptionsToTest())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug fix.

@marcobebway
Copy link
Contributor Author

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
@kyma-bot kyma-bot merged commit dd05d72 into kyma-project:main Mar 14, 2024
14 checks passed
@marcobebway marcobebway deleted the remove-subscription-v1alpha1-tests branch March 14, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants