feat: remove v1alpha1 subscription #517

marcobebway · 2024-03-05T16:13:14Z

Description

Remove v1alpha1 subscription.

Related issue(s)

Remove Subscription v1alpha1 version #442

marcobebway · 2024-03-05T16:13:24Z

/hold

marcobebway · 2024-03-12T10:28:49Z

pkg/eventing/manager.go

@@ -284,14 +283,3 @@ func (em *EventingManager) SubscriptionExists(ctx context.Context) (bool, error)
 	}
 	return false, nil
 }
-
-func convertECBackendType(backendType v1alpha1.BackendType) (eventingv1alpha1.BackendType, error) {


Removed because it is not used.

marcobebway · 2024-03-13T06:19:08Z

/test pull-eventing-manager-build

marcobebway · 2024-03-13T06:22:44Z

/retest

NHingerl

I assume that the table is automatically generated and the suggestions should be applied to the source documents.

NHingerl · 2024-03-13T12:26:57Z

docs/user/02-configuration.md

+| **backend**  | object | Backend defines the active backend used by Eventing. |
+| **backend.&#x200b;config**  | object | Config defines configuration for eventing backend. |
+| **backend.&#x200b;config.&#x200b;domain**  | string | Domain defines the cluster public domain used to configure the EventMesh Subscriptions
+and their corresponding ApiRules. |


weird line break

NHingerl · 2024-03-13T12:27:15Z

docs/user/02-configuration.md

+| ---- | ----------- | ---- |
+| **annotations**  | map\[string\]string | Annotations allows to add annotations to resources. |
+| **backend**  | object | Backend defines the active backend used by Eventing. |
+| **backend.&#x200b;config**  | object | Config defines configuration for eventing backend. |


NHingerl · 2024-03-13T12:27:34Z

docs/user/02-configuration.md

+| **backend.&#x200b;config**  | object | Config defines configuration for eventing backend. |
+| **backend.&#x200b;config.&#x200b;domain**  | string | Domain defines the cluster public domain used to configure the EventMesh Subscriptions
+and their corresponding ApiRules. |
+| **backend.&#x200b;config.&#x200b;eventMeshSecret**  | string | EventMeshSecret defines the namespaced name of K8s Secret containing EventMesh credentials. The format of name is "namespace/name". |


Suggested change

| **backend.config.eventMeshSecret** | string | EventMeshSecret defines the namespaced name of K8s Secret containing EventMesh credentials. The format of name is "namespace/name". |

| **backend.config.eventMeshSecret** | string | EventMeshSecret defines the namespaced name of the Kubernetes Secret containing EventMesh credentials. The format of name is "namespace/name". |

NHingerl · 2024-03-13T12:28:08Z

docs/user/02-configuration.md

+| **backend.&#x200b;config.&#x200b;eventTypePrefix**  | string |  |
+| **backend.&#x200b;config.&#x200b;natsMaxMsgsPerTopic**  | integer | NATSMaxMsgsPerTopic limits how many messages in the NATS stream to retain per subject. |
+| **backend.&#x200b;config.&#x200b;natsStreamMaxSize**  | \{integer or string\} | NATSStreamMaxSize defines the maximum storage size for stream data. |
+| **backend.&#x200b;config.&#x200b;natsStreamReplicas**  | integer | NATSStreamReplicas defines the number of replicas for stream. |


NHingerl · 2024-03-13T12:28:45Z

docs/user/02-configuration.md

+| **publisher.&#x200b;replicas.&#x200b;min**  | integer | Min defines minimum number of replicas. |
+| **publisher.&#x200b;resources**  | object | Resources defines resources for eventing-publisher-proxy. |
+| **publisher.&#x200b;resources.&#x200b;claims**  | \[\]object | Claims lists the names of resources, defined in spec.resourceClaims,
+that are used by this container.


weird line break

NHingerl · 2024-03-13T12:33:52Z

docs/user/02-configuration.md

+| **conditions.&#x200b;message** (required) | string | message is a human readable message indicating details about the transition.
+This may be an empty string. |
+| **conditions.&#x200b;observedGeneration**  | integer | observedGeneration represents the .metadata.generation that the condition was set based upon.
+For instance, if .metadata.generation is currently 12, but the .status.conditions[x].observedGeneration is 9, the condition is out of date


Suggested change

For instance, if .metadata.generation is currently 12, but the .status.conditions[x].observedGeneration is 9, the condition is out of date

For example, if .metadata.generation is currently 12, but the .status.conditions[x].observedGeneration is 9, the condition is out of date

NHingerl · 2024-03-13T12:34:45Z

docs/user/02-configuration.md

+and whether the values are considered a guaranteed API.
+The value should be a CamelCase string.
+This field may not be empty. |
+| **conditions.&#x200b;status** (required) | string | status of the condition, one of True, False, Unknown. |


NHingerl · 2024-03-13T12:35:27Z

docs/user/02-configuration.md

+| **conditions.&#x200b;status** (required) | string | status of the condition, one of True, False, Unknown. |
+| **conditions.&#x200b;type** (required) | string | type of condition in CamelCase or in foo.example.com/CamelCase.
+---
+Many .condition.type values are consistent across resources like Available, but because arbitrary conditions can be


Suggested change

Many .condition.type values are consistent across resources like Available, but because arbitrary conditions can be

Many .condition.type values, like Available, are consistent across resources, but because arbitrary conditions can be

I think this is what you mean?

NHingerl · 2024-03-13T12:36:17Z

docs/user/02-configuration.md

+| **specHash** (required) | integer |  |
+| **state** (required) | string | Can have one of the following values: Ready, Error, Processing, Warning. Ready state is set
+when all the resources are deployed successfully and backend is connected.
+It gets Warning state in case backend is not specified, NATS module is not installed, or EventMesh secret is missing in the cluster.


Suggested change

It gets Warning state in case backend is not specified, NATS module is not installed, or EventMesh secret is missing in the cluster.

It gets Warning state if no backend is specified, NATS module is not installed, or EventMesh secret is missing in the cluster.

NHingerl · 2024-03-13T12:37:25Z

docs/user/02-configuration.md

+| **state** (required) | string | Can have one of the following values: Ready, Error, Processing, Warning. Ready state is set
+when all the resources are deployed successfully and backend is connected.
+It gets Warning state in case backend is not specified, NATS module is not installed, or EventMesh secret is missing in the cluster.
+Error state is set when there is an error. Processing state is set if recources are being created or changed. |


does this mean "backend not specified, NATs module not installed, Secret missing" are not errors?
The explanation for "Warning" is very specific, and the explanation for "Error" is extremely vague. Can we improve that?

marcobebway · 2024-03-13T13:15:29Z

@NHingerl the doc changes are auto generated. I will revert those changes for now, and will do it in a separate PR.

marcobebway · 2024-03-14T10:46:05Z

/hold cancel

marcobebway requested review from a team as code owners March 5, 2024 16:13

marcobebway requested a review from mfaizanse March 5, 2024 16:13

kyma-bot added area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. labels Mar 5, 2024

kyma-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 5, 2024

marcobebway linked an issue Mar 5, 2024 that may be closed by this pull request

Remove Subscription v1alpha1 version #442

Closed

8 tasks

marcobebway self-assigned this Mar 5, 2024

marcobebway force-pushed the 442-remove-v1alpha1-subscription branch from a705919 to 355c390 Compare March 7, 2024 13:30

NHingerl previously approved these changes Mar 7, 2024

View reviewed changes

kyma-bot assigned NHingerl Mar 7, 2024

kyma-bot added the lgtm Looks good to me! label Mar 7, 2024

marcobebway commented Mar 12, 2024

View reviewed changes

marcobebway dismissed NHingerl’s stale review via 39c98d3 March 12, 2024 17:20

marcobebway force-pushed the 442-remove-v1alpha1-subscription branch from ce9c8f7 to 39c98d3 Compare March 12, 2024 17:20

kyma-bot removed the lgtm Looks good to me! label Mar 12, 2024

NHingerl previously approved these changes Mar 13, 2024

View reviewed changes

kyma-bot added the lgtm Looks good to me! label Mar 13, 2024

marcobebway dismissed NHingerl’s stale review via 1268213 March 13, 2024 11:38

marcobebway force-pushed the 442-remove-v1alpha1-subscription branch from 39c98d3 to 1268213 Compare March 13, 2024 11:38

kyma-bot removed the lgtm Looks good to me! label Mar 13, 2024

NHingerl reviewed Mar 13, 2024

View reviewed changes

mfaizanse previously approved these changes Mar 13, 2024

View reviewed changes

kyma-bot assigned mfaizanse Mar 13, 2024

kyma-bot added the lgtm Looks good to me! label Mar 13, 2024

marcobebway dismissed mfaizanse’s stale review via 2882210 March 13, 2024 13:12

kyma-bot removed the lgtm Looks good to me! label Mar 13, 2024

marcobebway requested review from NHingerl and mfaizanse March 13, 2024 13:14

mfaizanse previously approved these changes Mar 13, 2024

View reviewed changes

kyma-bot added the lgtm Looks good to me! label Mar 13, 2024

marcobebway removed the request for review from NHingerl March 13, 2024 13:17

NHingerl previously approved these changes Mar 13, 2024

View reviewed changes

marcobebway added 8 commits March 14, 2024 10:14

feat: remove subscription v1alpha1

e684205

update crd

fafcbce

update docs

7515fd5

codegen

fd80fda

fix tests

e7446c6

Add tests for exact type matching

f35716f

fix tests

b9d1b61

Undo doc changes

73040a7

marcobebway dismissed stale reviews from NHingerl and mfaizanse via 73040a7 March 14, 2024 09:22

marcobebway force-pushed the 442-remove-v1alpha1-subscription branch from 2882210 to 73040a7 Compare March 14, 2024 09:22

kyma-bot removed the lgtm Looks good to me! label Mar 14, 2024

marcobebway requested review from mfaizanse and NHingerl and removed request for NHingerl March 14, 2024 09:32

mfaizanse approved these changes Mar 14, 2024

View reviewed changes

kyma-bot added the lgtm Looks good to me! label Mar 14, 2024

kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024

kyma-bot merged commit 0347ee0 into kyma-project:main Mar 14, 2024
15 checks passed

marcobebway deleted the 442-remove-v1alpha1-subscription branch March 14, 2024 10:48

marcobebway mentioned this pull request Mar 19, 2024

fix: the Eventing API docs #539

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: remove v1alpha1 subscription #517

feat: remove v1alpha1 subscription #517

marcobebway commented Mar 5, 2024 •

edited

Loading

marcobebway commented Mar 5, 2024

marcobebway Mar 12, 2024

marcobebway commented Mar 13, 2024

marcobebway commented Mar 13, 2024

NHingerl left a comment

NHingerl Mar 13, 2024

NHingerl Mar 13, 2024

NHingerl Mar 13, 2024

NHingerl Mar 13, 2024

NHingerl Mar 13, 2024

NHingerl Mar 13, 2024

NHingerl Mar 13, 2024

NHingerl Mar 13, 2024

NHingerl Mar 13, 2024

NHingerl Mar 13, 2024

marcobebway commented Mar 13, 2024 •

edited

Loading

marcobebway commented Mar 14, 2024

	\| backend.config \| object \| Config defines configuration for eventing backend. \|
	\| backend.config \| object \| Config defines configuration for the Eventing backend. \|

	\| backend.config.eventMeshSecret \| string \| EventMeshSecret defines the namespaced name of K8s Secret containing EventMesh credentials. The format of name is "namespace/name". \|
	\| backend.config.eventMeshSecret \| string \| EventMeshSecret defines the namespaced name of the Kubernetes Secret containing EventMesh credentials. The format of name is "namespace/name". \|

	\| backend.config.natsStreamReplicas \| integer \| NATSStreamReplicas defines the number of replicas for stream. \|
	\| backend.config.natsStreamReplicas \| integer \| NATSStreamReplicas defines the number of replicas for each stream. \|

	For instance, if .metadata.generation is currently 12, but the .status.conditions[x].observedGeneration is 9, the condition is out of date
	For example, if .metadata.generation is currently 12, but the .status.conditions[x].observedGeneration is 9, the condition is out of date

	\| conditions.status (required) \| string \| status of the condition, one of True, False, Unknown. \|
	\| conditions.status (required) \| string \| status of the condition, value must be either True, False, or Unknown. \|

	Many .condition.type values are consistent across resources like Available, but because arbitrary conditions can be
	Many .condition.type values, like Available, are consistent across resources, but because arbitrary conditions can be

	It gets Warning state in case backend is not specified, NATS module is not installed, or EventMesh secret is missing in the cluster.
	It gets Warning state if no backend is specified, NATS module is not installed, or EventMesh secret is missing in the cluster.

feat: remove v1alpha1 subscription #517

feat: remove v1alpha1 subscription #517

Conversation

marcobebway commented Mar 5, 2024 • edited Loading

marcobebway commented Mar 5, 2024

Choose a reason for hiding this comment

marcobebway commented Mar 13, 2024

marcobebway commented Mar 13, 2024

NHingerl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcobebway commented Mar 13, 2024 • edited Loading

marcobebway commented Mar 14, 2024

marcobebway commented Mar 5, 2024 •

edited

Loading

marcobebway commented Mar 13, 2024 •

edited

Loading