Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: malformatted EventMesh Secret causes warning state instead of Error state #511

Closed
wants to merge 8 commits into from
Closed

feat: malformatted EventMesh Secret causes warning state instead of Error state #511

wants to merge 8 commits into from

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Mar 1, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • when the reconciler finds a EventMesh Secret that cannot be read due to missing fields or wrong formatting, it will return the warning state, not the error state, to indicate re requirement of user interactions.

Related issue(s)

@friedrichwilken friedrichwilken requested a review from a team as a code owner March 1, 2024 12:16
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 1, 2024
@friedrichwilken friedrichwilken changed the title Bad em secret causes warning feat: malformed EventMesh Secret causes warning state instead of Error state Mar 4, 2024
@friedrichwilken friedrichwilken added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2024
@friedrichwilken friedrichwilken changed the title feat: malformed EventMesh Secret causes warning state instead of Error state feat: malformatted EventMesh Secret causes warning state instead of Error state Mar 4, 2024
This was referenced Mar 4, 2024
Closed
Closed
@friedrichwilken friedrichwilken linked an issue Mar 5, 2024 that may be closed by this pull request
Set warning to Eventing CR state if EventMesh secret is malformatted #490
Closed
@friedrichwilken friedrichwilken requested review from marcobebway and removed request for mfaizanse March 5, 2024 09:24
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2024
@friedrichwilken friedrichwilken force-pushed the bad-em-secret-causes-warning branch 10 times, most recently from 31ba29a to 892c43a Compare March 6, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcobebway marcobebway Awaiting requested review from marcobebway

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set warning to Eventing CR state if EventMesh secret is malformatted
2 participants
@friedrichwilken @kyma-bot