Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default CR have empty backend #419

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

grischperl
Copy link
Collaborator

Description

The change to no longer have a default backend requires the default CR to not have a backend defined.

Changes proposed in this pull request:

  • Default CR has empty backend
  • CR with NATS backend in samples provided

Related issue(s)

@grischperl grischperl requested a review from a team as a code owner January 18, 2024 15:04
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 18, 2024
@kyma-bot kyma-bot merged commit b33cbaf into kyma-project:release-1.1 Jan 18, 2024
12 checks passed
friedrichwilken pushed a commit to friedrichwilken/eventing-manager that referenced this pull request Jan 23, 2024
kyma-bot pushed a commit that referenced this pull request Jan 24, 2024
@grischperl grischperl modified the milestone: 1.2.0 Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants