Skip to content

Commit

Permalink
refactor: added event types in e2e tests (#529)
Browse files Browse the repository at this point in the history
* refactor: added event types in e2e tests

* moved checkout step before running e2e tests in upgrade job
  • Loading branch information
mfaizanse authored Mar 11, 2024
1 parent 91d808c commit 5297bfe
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/e2e-upgrade-test-reusable.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ jobs:
echo "Pre-upgrade image: $pre_upgrade_image"
make deploy IMG=$pre_upgrade_image
- name: Checkout
uses: actions/checkout@v4
with:
ref: ${{ inputs.commit-sha }}

- name: Create test resources and wait for eventing CR readiness
run: |
export MANAGER_IMAGE=$DOCKER_IMAGE_REPO:${{ inputs.pre-upgrade-image-tag }}
Expand All @@ -97,11 +102,6 @@ jobs:
GITHUB_OWNER: "${{ github.repository_owner }}"
GITHUB_REPO: "eventing-manager"

- name: Checkout
uses: actions/checkout@v4
with:
ref: ${{ inputs.commit-sha }}

- name: Upgrade Eventing manager
id: upgrade-eventing-manager
run: |
Expand Down
9 changes: 9 additions & 0 deletions hack/e2e/common/fixtures/fixtures.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,15 @@ func V1Alpha2SubscriptionsToTest() []eventing.TestSubscriptionInfo {
"order.testing.v1",
},
},
{
Name: "test-sub-4-with-multiple-types-v1alpha2",
Description: "multiple types in same subscription",
Source: "test-evnt",
Types: []string{
"New.Some-Other.Order-äöüÄÖÜβ.Final.C-r-e-a-t-e-d.v1",
"DocuSing_BO.Account_DocuSign.Updated.v1",
},
},
}
}

Expand Down

0 comments on commit 5297bfe

Please sign in to comment.