Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code linter job #117

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Update code linter job #117

merged 3 commits into from
Feb 8, 2024

Conversation

marcobebway
Copy link
Contributor

@marcobebway marcobebway commented Feb 8, 2024 •
edited
Loading

Description

Update code linter job to use the centralized linting config from the eventing-tools repository.

Hints for reviewers

  • This PR also fixes the godox linter issues.
  • I removed the TODOs mentioned in this file controllers/eventingauth_controller.go because they are no longer relevant.

Related PRs

  • The current PR is a follow up to this PR which adds the needed import aliases used by the eventing-auth-manager repository.

@marcobebway marcobebway requested a review from a team as a code owner February 8, 2024 14:06
@marcobebway marcobebway self-assigned this Feb 8, 2024
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 8, 2024
@kyma-bot kyma-bot merged commit c0c58e7 into kyma-project:main Feb 8, 2024
6 checks passed
k15r pushed a commit to k15r/eventing-auth-manager that referenced this pull request Feb 21, 2024
@marcobebway @k15r
Update code linter job (kyma-project#117)
f55bd29 
* Update code linter job

* Update lint config URI

* Fix lint issues for godox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichwilken friedrichwilken friedrichwilken approved these changes

@grischperl grischperl Awaiting requested review from grischperl grischperl is a code owner automatically assigned from kyma-project/eventing

Assignees

@marcobebway marcobebway

@friedrichwilken friedrichwilken

Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcobebway @friedrichwilken @kyma-bot