Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisioner - fully remove obsolete code for runtime registration/deregistration in compass #3411

Merged

Conversation

koala7659
Copy link
Contributor

@koala7659 koala7659 commented Mar 15, 2024

All code that is responsible for connectivity of runtime with Compass has been moved to compass-manager service.

From now on the Provisioner will be only responsible for runtime creation/delete/shoot upgrade

This PR contains removal of all obsolete code and adjustments of unit tests

@koala7659 koala7659 requested a review from a team as a code owner March 15, 2024 11:39
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 15, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 15, 2024
@koala7659 koala7659 self-assigned this Mar 19, 2024
@koala7659 koala7659 changed the title [WiP] Remove obsolete code for runtime registration deregistration in compass [WiP] Provisioner - fully remove obsolete code for runtime registration deregistration in compass Mar 20, 2024
@koala7659 koala7659 changed the title [WiP] Provisioner - fully remove obsolete code for runtime registration deregistration in compass [WiP] Provisioner - fully remove obsolete code for runtime registration/deregistration in compass Mar 20, 2024
@koala7659 koala7659 changed the title [WiP] Provisioner - fully remove obsolete code for runtime registration/deregistration in compass Provisioner - fully remove obsolete code for runtime registration/deregistration in compass May 6, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 7, 2024
@kyma-bot kyma-bot merged commit ff9c054 into kyma-project:main May 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants