-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provisioner - fully remove obsolete code for runtime registration/deregistration in compass #3411
Merged
kyma-bot
merged 20 commits into
kyma-project:main
from
koala7659:remove-fully-compass-integration
May 7, 2024
Merged
Provisioner - fully remove obsolete code for runtime registration/deregistration in compass #3411
kyma-bot
merged 20 commits into
kyma-project:main
from
koala7659:remove-fully-compass-integration
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
cla: yes
Indicates the PR's author has signed the CLA.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Mar 15, 2024
kyma-bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Mar 15, 2024
koala7659
changed the title
[WiP] Remove obsolete code for runtime registration deregistration in compass
[WiP] Provisioner - fully remove obsolete code for runtime registration deregistration in compass
Mar 20, 2024
koala7659
changed the title
[WiP] Provisioner - fully remove obsolete code for runtime registration deregistration in compass
[WiP] Provisioner - fully remove obsolete code for runtime registration/deregistration in compass
Mar 20, 2024
23 tasks
6 tasks
koala7659
changed the title
[WiP] Provisioner - fully remove obsolete code for runtime registration/deregistration in compass
Provisioner - fully remove obsolete code for runtime registration/deregistration in compass
May 6, 2024
kyma-bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
May 6, 2024
akgalwas
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All code that is responsible for connectivity of runtime with Compass has been moved to compass-manager service.
From now on the Provisioner will be only responsible for runtime creation/delete/shoot upgrade
This PR contains removal of all obsolete code and adjustments of unit tests