Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GcpNfsVolume): add API validators #791

Merged

Conversation

dushanpantic
Copy link
Contributor

@dushanpantic dushanpantic commented Nov 8, 2024

Description

Changes proposed in this pull request:

  • adds custom, tier-based API validation to the GcpNfsVolume

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 8, 2024
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2024
@dushanpantic dushanpantic removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
@dushanpantic dushanpantic marked this pull request as ready for review November 13, 2024 13:06
@dushanpantic dushanpantic requested a review from a team as a code owner November 13, 2024 13:06
Copy link
Contributor

@ravi-shankar-sap ravi-shankar-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 13, 2024
@dushanpantic dushanpantic changed the title feat(GcpNfsVolume): add API validators for non-deprecated tiers feat(GcpNfsVolume): add API validators Nov 14, 2024
@dushanpantic dushanpantic merged commit cc6a60a into kyma-project:main Nov 14, 2024
14 of 15 checks passed
@dushanpantic dushanpantic deleted the gcpnfsvolume-constraints-for-api branch November 14, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants