Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AzureRedisInstance): add Azure redis instance to subnet #524

Closed

Conversation

ijovovic
Copy link
Contributor

Changes proposed in this pull request:

  • Add Redis instance to subnet designed for CM resources
  • If that subnet does not exists, create it by carving out the CIDR and put the Subnet in the same ResourceGroup as Nodes

Related issue(s)
#480

@ijovovic ijovovic requested a review from a team as a code owner August 23, 2024 09:58
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2024
Copy link
Contributor

@dushanpantic dushanpantic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the code, I am unable to find where the provisioned subnet is deleted.
Is it deleted automatically?
It must not be left hanging.

Also, in my opinion, if possible, cdir allocation should be provided via Azure IpRange implementation. That way it will match our other providers.

state.Scope().Spec.Scope.Azure.Network.Pods,
state.Scope().Spec.Scope.Azure.Network.Services,
}
cidr, error := iprangeallocate.AllocateCidr(22, existingRanges)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allocates a /22 block, which is 1024 addresses. Are you sure we need that many?

@ijovovic
Copy link
Contributor Author

Closing, not relevant any more as new impl is merged into main branch.

@ijovovic ijovovic closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants