Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement INSTALLED and MANAGED headers for table view when listing modules #2263

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Nov 28, 2024

Description

Changes proposed in this pull request:

  • implement new headers (INSTALLED and MANAGED)
  • the INSTALLED contains installed version with channel
  • the MANAGED is a boolean value that informs if a module is installed via the KymaCR and has the .managed field set to true

The xample module list output:

NAME                    VERSIONS                        INSTALLED                       MANAGED
docker-registry         0.3.0, 0.4.0
keda                    1.2.0, 1.3.0(regular),
                        1.4.0(fast),
                        1.5.0(experimental)
serverless              1.5.0(regular), 1.5.1,
                        1.6.0(fast)
template-operator       0.0.1-catalog-meta(regular),    0.0.2-catalog-meta(fast)        true
                        0.0.2-catalog-meta(fast)

Related issue(s)

#2253

@pPrecel pPrecel added kind/feature Categorizes issue or PR as related to a new feature. area/cli Related to all activities around CLI labels Nov 28, 2024
@pPrecel pPrecel requested a review from a team as a code owner November 28, 2024 09:35
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2024
@pPrecel pPrecel force-pushed the kyma-module-list-managed branch from 7113fa9 to e53effc Compare November 28, 2024 19:27
Copy link
Member

@halamix2 halamix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/pony

@kyma-bot
Copy link

@halamix2: pony image

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 28, 2024
@pPrecel pPrecel merged commit 957c22b into kyma-project:main Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants