Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support coreCommands extensions #2233

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Oct 31, 2024

Description

Changes proposed in this pull request:

  • remove registry commands group
  • support coreCommands in extension configmap
  • enable image-import and config commands if registry configmap exists

Related issue(s)

@pPrecel pPrecel added kind/feature Categorizes issue or PR as related to a new feature. area/cli Related to all activities around CLI labels Oct 31, 2024
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2024
@pPrecel
Copy link
Contributor Author

pPrecel commented Oct 31, 2024

To test this functionality add the following ConfigMap with the registry extension:

apiVersion: v1
kind: ConfigMap
metadata:
  labels:
    kyma-cli/extension: resource
  name: registry.extension.cli
data:
  rootCommand: |
    name: registry
    description: Set of commands for Kyma registry
    descriptionLong: Use this command manage resources related to Kyma registry

  coreCommands: |
    - actionID: registry_config
    - actionID: registry_image-import

Now spells like

  • go run main.go alpha registry
  • go run main.go alpha registry config
  • go run main.go alpha registry image-import

can be used

@pPrecel pPrecel marked this pull request as ready for review October 31, 2024 09:42
@pPrecel pPrecel requested a review from a team as a code owner October 31, 2024 09:42
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2024
@MichalKalke MichalKalke self-assigned this Oct 31, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 4, 2024
@pPrecel pPrecel merged commit f1d9c1b into kyma-project:main Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants