feat: Add new EnableModuleConfig flag #2007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
cla: yes
amritanshusikdar
changed the title
amritanshusikdar
force-pushed
the
add-new-sync-flag
branch
from
5966a2e
to
206745a
Compare
kyma-bot
added
size/L
kyma-bot
removed
the
do-not-merge/work-in-progress
There was a problem hiding this comment.
After merging kyma-project/lifecycle-manager#1398 (review)
Please also update the dependency to the new API, so it actullay sets the spec field
|
As per the discussion in the team, temporarily closing this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to Update CLI module create command to include the
EnableModuleConfigflag in module-config-file.Related issue(s)
Resolves LM Issue 1371