Lint tests (#2216)

.golangci.yaml

@@ -1,7 +1,6 @@
 run:
   modules-download-mode: readonly
   timeout: 15m
-  tests: false
 linters:
   disable-all: true
   enable:
@@ -23,3 +22,7 @@ issues:
     - "unexported-return:"
     - "context-as-argument:"
     - "and that stutters"
+    - '`fixTestDeployment` - `namespace` always receives `"kyma-system"'
+    - "`fixCheckConfig` - `name` always receives `name`"
+    - "`fixCheckConfig` - `namespace` always receives `namespace`"
+    - "`fixTestHanaServiceBinding` - `namespace` always receives `namespace"

internal/communitymodules/modules_test.go

@@ -237,7 +237,7 @@ func Test_installedModules(t *testing.T) {
 func fixHttpResponseHandler(status int, response string) func(http.ResponseWriter, *http.Request) {
 	return func(w http.ResponseWriter, _ *http.Request) {
 		w.WriteHeader(status)
-		w.Write([]byte(response))
+		_, _ = w.Write([]byte(response))
 	}
 }
 

internal/kube/kyma/kyma_test.go

@@ -131,8 +131,6 @@ func TestUpdateDefaultKyma(t *testing.T) {
 
 func Test_disableModule(t *testing.T) {
 	t.Parallel()
-	type args struct {
-	}
 	tests := []struct {
 		name       string
 		kymaCR     *Kyma

internal/registry/portforward/transport_test.go

@@ -178,7 +178,7 @@ func fixDataStreamMock(t *testing.T, req *http.Request, resp *http.Response) htt
 	reqBytes := reqBuf.Bytes()
 
 	responseBuf := bytes.NewBuffer([]byte{})
-	resp.Write(responseBuf)
+	_ = resp.Write(responseBuf)
 
 	dataStreamMock := automock.NewStream(t)
 	dataStreamMock.On("Close").Return(nil).Twice()