remove redundant --module flag from manage & unmanage commands (#2331)

kyma-project · Jan 22, 2025 · 5ea93f7 · 5ea93f7
1 parent c52e669
commit 5ea93f7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/internal/cmd/alpha/module/manage.go b/internal/cmd/alpha/module/manage.go
@@ -23,18 +23,17 @@ func newManageCMD(kymaConfig *cmdcommon.KymaConfig) *cobra.Command {
 		Use:   "manage <module>",
 		Short: "Manage module.",
 		Long:  "Use this command to manage an existing module.",
-
+		Args:  cobra.ExactArgs(1),
 		PreRun: func(_ *cobra.Command, args []string) {
 			clierror.Check(cfg.validate())
 		},
 		Run: func(cmd *cobra.Command, args []string) {
+			cfg.module = args[0]
 			clierror.Check(runManage(&cfg))
 		},
 	}
 
-	cmd.Flags().StringVar(&cfg.module, "module", "", "Name of the module to manage")
 	cmd.Flags().StringVar(&cfg.policy, "policy", "CreateAndDelete", "Set custom resource policy. (Possible values: CreateAndDelete, Ignore)")
-	_ = cmd.MarkFlagRequired("module")
 	return cmd
 }
 

diff --git a/internal/cmd/alpha/module/unmanage.go b/internal/cmd/alpha/module/unmanage.go
@@ -21,13 +21,13 @@ func newUnmanageCMD(kymaConfig *cmdcommon.KymaConfig) *cobra.Command {
 		Use:   "unmanage <module>",
 		Short: "Unmanage module.",
 		Long:  "Use this command to unmanage an existing module.",
+		Args:  cobra.ExactArgs(1),
 		Run: func(cmd *cobra.Command, args []string) {
+			cfg.module = args[0]
 			clierror.Check(runUnmanage(&cfg))
 		},
 	}
 
-	cmd.Flags().StringVar(&cfg.module, "module", "", "Name of the module to unmanage")
-	_ = cmd.MarkFlagRequired("module")
 	return cmd
 }