Set correct policy after module unmanage (#2317)

kyma-project · Jan 16, 2025 · 50e5878 · 50e5878
1 parent a9ca132
commit 50e5878
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/internal/kube/kyma/kyma.go b/internal/kube/kyma/kyma.go
@@ -294,6 +294,7 @@ func unmanageModule(kymaCR *Kyma, moduleName string) (*Kyma, error) {
 		if m.Name == moduleName {
 			// module exists, update managed
 			kymaCR.Spec.Modules[i].Managed = ptr.To(false)
+			kymaCR.Spec.Modules[i].CustomResourcePolicy = "Ignore"
 
 			return kymaCR, nil
 		}

diff --git a/internal/kube/kyma/kyma_test.go b/internal/kube/kyma/kyma_test.go
@@ -760,8 +760,9 @@ func Test_unmanageModule(t *testing.T) {
 				Spec: KymaSpec{
 					Modules: []Module{
 						{
-							Name:    "module",
-							Managed: ptr.To(false),
+							Name:                 "module",
+							Managed:              ptr.To(false),
+							CustomResourcePolicy: "Ignore",
 						},
 					},
 				},
@@ -770,8 +771,9 @@ func Test_unmanageModule(t *testing.T) {
 				Spec: KymaSpec{
 					Modules: []Module{
 						{
-							Name:    "module",
-							Managed: ptr.To(false),
+							Name:                 "module",
+							Managed:              ptr.To(false),
+							CustomResourcePolicy: "Ignore",
 						},
 					},
 				},
@@ -784,8 +786,9 @@ func Test_unmanageModule(t *testing.T) {
 				Spec: KymaSpec{
 					Modules: []Module{
 						{
-							Name:    "module",
-							Managed: ptr.To(true),
+							Name:                 "module",
+							Managed:              ptr.To(true),
+							CustomResourcePolicy: "CreateAndDelete",
 						},
 					},
 				},
@@ -794,8 +797,9 @@ func Test_unmanageModule(t *testing.T) {
 				Spec: KymaSpec{
 					Modules: []Module{
 						{
-							Name:    "module",
-							Managed: ptr.To(false),
+							Name:                 "module",
+							Managed:              ptr.To(false),
+							CustomResourcePolicy: "Ignore",
 						},
 					},
 				},