Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add APIRules v1beta1 deprecation information in the UI #1448

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Add APIRules v1beta1 deprecation information in the UI #1448

merged 6 commits into from
Nov 14, 2024

Conversation

triffer
Copy link
Collaborator

@triffer triffer commented Nov 13, 2024

Description

Changes proposed in this pull request:

  • Add banner on v1beta1 APIRule list and APIRule details that will inform about v1beta1 deprecation

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@triffer triffer requested a review from a team as a code owner November 13, 2024 06:42
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2024
@triffer triffer mentioned this pull request Nov 13, 2024
Open
4 tasks
@triffer triffer requested a review from a team as a code owner November 13, 2024 07:24
Ressetkk
Ressetkk previously approved these changes Nov 13, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 13, 2024
@Ressetkk Ressetkk self-requested a review November 13, 2024 10:06
@Ressetkk
Copy link
Collaborator

LGTM, but UI tests got broken.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 13, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 14, 2024
@triffer triffer merged commit b547360 into kyma-project:main Nov 14, 2024
20 checks passed
@triffer triffer deleted the deprecation-ui branch November 14, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliasitko nataliasitko nataliasitko approved these changes

@Ressetkk Ressetkk Awaiting requested review from Ressetkk

Assignees

@Ressetkk Ressetkk

@nataliasitko nataliasitko

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@triffer @Ressetkk @nataliasitko @kyma-bot