Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtAuth handler #1258

Merged
merged 43 commits into from
Sep 10, 2024
Merged

ExtAuth handler #1258

merged 43 commits into from
Sep 10, 2024

Conversation

barchw
Copy link
Collaborator

@barchw barchw commented Aug 19, 2024 •
edited by triffer
Loading

Description

Changes proposed in this pull request:

  • Add ExtAuth handler to v2alpha1 APIRule

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 19, 2024
@barchw barchw changed the title AuthorizationPolicy processor for ExtAuth ExtAuth handler Aug 19, 2024
@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 19, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 26, 2024
@barchw barchw marked this pull request as ready for review August 26, 2024 13:52
@barchw barchw requested a review from a team as a code owner August 26, 2024 13:52
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2024
Ressetkk
Ressetkk previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@Ressetkk Ressetkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as of now.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 10, 2024
@kolodziejczak kolodziejczak requested review from kolodziejczak and removed request for kolodziejczak September 10, 2024 08:49
@kolodziejczak kolodziejczak removed their assignment Sep 10, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 10, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 10, 2024
@kyma-bot kyma-bot merged commit 19d1639 into kyma-project:main Sep 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolodziejczak kolodziejczak kolodziejczak left review comments

@triffer triffer triffer left review comments

@nataliasitko nataliasitko nataliasitko approved these changes

@Ressetkk Ressetkk Ressetkk left review comments

Assignees

@Ressetkk Ressetkk

@nataliasitko nataliasitko

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@barchw @kyma-bot @Ressetkk @triffer @kolodziejczak @nataliasitko