Skip to content

Commit

Permalink
Remove debug cli (#332)
Browse files Browse the repository at this point in the history
* Remove debug cli

* fix readme
  • Loading branch information
kylebarron authored Sep 18, 2023
1 parent 5ea2af9 commit 35548cc
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 325 deletions.
155 changes: 9 additions & 146 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 1 addition & 20 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ async = [
"dep:async-stream",
"parquet?/async",
]
debug = ["console_error_panic_hook", "clap"]
debug = ["console_error_panic_hook"]

brotli = ["parquet?/brotli", "parquet2?/brotli"]
gzip = ["parquet?/flate2", "parquet2?/gzip"]
Expand Down Expand Up @@ -97,9 +97,6 @@ bytes = { version = "1", optional = true }

serde-wasm-bindgen = { version = "0.6", optional = true }

# 3.2 added deprecations that don't currently pass clippy
clap = { version = ">=3.1.15, <3.3", optional = true, features = ["derive"] }

wasm-bindgen-futures = { version = "0.4.30", optional = true }
futures = { version = "0.3", optional = true }
range-reader = { version = "0.2", optional = true }
Expand Down Expand Up @@ -143,22 +140,6 @@ skip_optional_dependencies = true
# Exclude certain features from the build matrix
denylist = ["full", "all_compressions", "default"]

[[bin]]
name = "read_parquet"
required-features = ["debug", "arrow1", "reader"]

[[bin]]
name = "write_parquet"
required-features = ["debug", "arrow1", "writer"]

[[bin]]
name = "read_parquet2"
required-features = ["debug", "arrow2", "reader"]

[[bin]]
name = "write_parquet2"
required-features = ["debug", "arrow2", "writer"]

[profile.release]
# Tell `rustc` to optimize for small code size.
# As of 3/15/22, opt-level = s was smallest
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ By default, `arrow`, `all_compressions`, `reader`, and `writer` features are ena
- `snappy`: Activate Snappy compression.
- `zstd`: Activate ZSTD compression.
- `lz4`: Activate LZ4_RAW compression (only applies to the `arrow2` endpoints).
- `debug`: Expose the `setPanicHook` function for better error messages for Rust panics. Additionally compiles CLI debug functions.
- `debug`: Expose the `setPanicHook` function for better error messages for Rust panics.

## Node <20

Expand Down
35 changes: 0 additions & 35 deletions src/bin/read_parquet.rs

This file was deleted.

34 changes: 0 additions & 34 deletions src/bin/read_parquet2.rs

This file was deleted.

Loading

0 comments on commit 35548cc

Please sign in to comment.