Make openvpn_custom_dns work as defined in Readme #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was using
openvpn_custom_dns
along withopenvpn_set_dns
astrue
and noticed it wasn't adding the servers to my openvpn config.Looking at the code it previously treated
openvpn_custom_dns
as if it was a Boolean, and instead usedopenvpn_dns_servers
to loop through the servers:It seemed to be suggesting that in our configs we set:
Which contradicted the docs which state:
I've tried to change it so we don't use
openvpn_dns_servers
at all, and the check for if we either add custom-servers vs the default DNS is based entirely on whether or notopenvpn_custom_dns
has entries in it.This makes it more in-line with what the README says
Potentially breaking changes
openvpn_dns_servers
(andopenvpn_custom_dns
:true
) it will no longer workopenvpn_custom_dns
without it actually writing them to config previously, it would now actually insert them which could potentially break