lint: fix some noisy clippy warning

src/action.rs

@@ -76,7 +76,7 @@ impl Action {
   }
 }
 
-#[derive(Debug, Clone, Copy, PartialEq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum CopyTarget {
   Line,
   Commandline(SupportedShell),
@@ -89,7 +89,7 @@ pub enum CopyTarget {
   EnvDiff,
 }
 
-#[derive(Debug, Clone, Copy, PartialEq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum SupportedShell {
   Bash,
   Sh,

src/arch.rs

@@ -3,13 +3,13 @@ use cfg_if::cfg_if;
 cfg_if! {
     if #[cfg(target_arch = "x86_64")] {
         pub mod x86_64;
-        pub(crate) use x86_64::*;
+        pub use x86_64::*;
     } else if #[cfg(target_arch = "aarch64")] {
         pub mod aarch64;
-        pub(crate) use aarch64::*;
+        pub use aarch64::*;
     } else if #[cfg(target_arch = "riscv64")] {
         pub mod riscv64;
-        pub(crate) use riscv64::*;
+        pub use riscv64::*;
     } else {
         compile_error!("unsupported architecture");
     }

src/bpf.rs

@@ -451,7 +451,7 @@ impl EbpfTracer {
             .as_ref()
             .map(|tx| filterable_event!(TraceeSpawn(child)).send_if_match(tx, self.filter))
             .transpose()?;
-          if let TracerMode::Log { foreground: true } = &self.mode {
+          if matches!(&self.mode, TracerMode::Log { foreground: true }) {
             match tcsetpgrp(stdin(), child) {
               Ok(_) => {}
               Err(Errno::ENOTTY) => {

src/bpf/interface.rs

@@ -2,7 +2,7 @@ use enumflags2::bitflags;
 
 #[bitflags]
 #[repr(u32)]
-#[derive(Copy, Clone, Debug, PartialEq)]
+#[derive(Copy, Clone, Debug, PartialEq, Eq)]
 #[allow(non_camel_case_types)]
 #[allow(clippy::upper_case_acronyms)]
 pub enum BpfEventFlags {

src/bpf/process_tracker.rs

@@ -46,11 +46,11 @@ impl ProcessTracker {
   }
 
   #[allow(unused)]
-  pub fn associated_events(&mut self, pid: Pid) -> &[u64] {
+  pub fn associated_events(&self, pid: Pid) -> &[u64] {
     &self.processes.get(&pid).unwrap().associated_events
   }
 
-  pub fn maybe_associated_events(&mut self, pid: Pid) -> Option<&[u64]> {
+  pub fn maybe_associated_events(&self, pid: Pid) -> Option<&[u64]> {
     self
       .processes
       .get(&pid)

src/cli.rs

@@ -213,7 +213,7 @@ impl Cli {
   }
 
   pub fn generate_completions(shell: clap_complete::Shell) {
-    let mut cmd = Cli::command();
+    let mut cmd = Self::command();
     clap_complete::generate(shell, &mut cmd, env!("CARGO_CRATE_NAME"), &mut stdout())
   }
 

src/cli/config.rs

@@ -29,7 +29,7 @@ pub enum ConfigLoadError {
 }
 
 impl Config {
-  pub fn load(path: Option<PathBuf>) -> Result<Config, ConfigLoadError> {
+  pub fn load(path: Option<PathBuf>) -> Result<Self, ConfigLoadError> {
     let config_text = match path {
       Some(path) => std::fs::read_to_string(path)?, // if manually specified config doesn't exist, return a hard error
       None => {
@@ -47,7 +47,7 @@ impl Config {
       }
     };
 
-    let config: Config = toml::from_str(&config_text)?;
+    let config: Self = toml::from_str(&config_text)?;
     Ok(config)
   }
 }

src/cli/options.rs

@@ -2,15 +2,15 @@ use clap::ValueEnum;
 use serde::{Deserialize, Serialize};
 use strum::Display;
 
-#[derive(Debug, Clone, Copy, ValueEnum, PartialEq, Display)]
+#[derive(Debug, Clone, Copy, ValueEnum, PartialEq, Eq, Display)]
 #[strum(serialize_all = "kebab-case")]
 pub enum Color {
   Auto,
   Always,
   Never,
 }
 
-#[derive(Debug, Clone, Copy, ValueEnum, PartialEq, Display, Default, Deserialize, Serialize)]
+#[derive(Debug, Clone, Copy, ValueEnum, PartialEq, Eq, Display, Default, Deserialize, Serialize)]
 #[strum(serialize_all = "kebab-case")]
 pub enum SeccompBpf {
   #[default]
@@ -19,15 +19,17 @@ pub enum SeccompBpf {
   Off,
 }
 
-#[derive(Debug, Clone, Copy, ValueEnum, PartialEq, Display, Default, Deserialize, Serialize)]
+#[derive(
+  Debug, Clone, Copy, ValueEnum, PartialEq, Eq, Display, Default, Deserialize, Serialize,
+)]
 #[strum(serialize_all = "kebab-case")]
 pub enum ActivePane {
   #[default]
   Terminal,
   Events,
 }
 
-#[derive(Debug, Clone, Copy, ValueEnum, PartialEq, Display, Deserialize, Serialize)]
+#[derive(Debug, Clone, Copy, ValueEnum, PartialEq, Eq, Display, Deserialize, Serialize)]
 #[strum(serialize_all = "kebab-case")]
 pub enum ExportFormat {
   // https://jsonlines.org/

src/cmdbuilder.rs

@@ -66,7 +66,7 @@ fn get_shell() -> String {
 
 /// `CommandBuilder` is used to prepare a command to be spawned into a pty.
 /// The interface is intentionally similar to that of `std::process::Command`.
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct CommandBuilder {
   args: Vec<OsString>,
   cwd: Option<OsString>,