Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiple naming strategies #45

Merged

Conversation

zzeekk
Copy link
Contributor

@zzeekk zzeekk commented Nov 8, 2020

Dear @kxbmap,

I really like your scala hocon config wrapper, but i'm not sure if you still maintain it. Version 0.5.0-SNAPSHOT is a nice refactoring, will there be a release soon?
I created the following PR which adds a feature which worked in 0.4.4 but no longer in 0.5.0. We like to combine multiple naming strategies, as our customers like to mix lowerCamelCase and hyphenSeparated in the same config object...

With this PR its possible to combine multiple ConfigKeyNaming's as follows:
ConfigKeyNaming.lowerCamelCase[A].or(ConfigKeyNaming.hyphenSeparated[A].apply)

Please let me know if you would support this or if you wish any changes.

Thanks and best regard, Zach

@zzeekk zzeekk closed this Nov 11, 2020
@zzeekk
Copy link
Contributor Author

zzeekk commented Nov 11, 2020

retrigger failed travis-ci build

@zzeekk zzeekk reopened this Nov 11, 2020
@kxbmap kxbmap merged commit bda2bd6 into kxbmap:master Nov 11, 2020
@kxbmap
Copy link
Owner

kxbmap commented Nov 11, 2020

Thanks for the PR.
As you may have guessed, I am less motivated for this library.
I had a couple of features I wanted to implement before releasing 0.5.0, but that won't allow me to release it forever, so I'm going to release it once this week.

@zzeekk
Copy link
Contributor Author

zzeekk commented Nov 11, 2020

Thanks for merging.
I have another PR which i would like to propose & merge before releasing. Its about checking for superfluous keys in the config. I could prepare it till next monday.
On the otherside it might be that you no longer want to maintain the project. If you would like to we could maintain it on our forked repository at https://github.com/smart-data-lake/configs and release 0.5.0 artifact under io.smartdatalake:configs.
But if you still like to care for PR and releases, there is no need from us to release from the fork... let me know how you feel about this.
Best regards, Zach

@zzeekk zzeekk deleted the feature/multiple-naming-strategies branch November 11, 2020 15:36
@kxbmap
Copy link
Owner

kxbmap commented Nov 12, 2020

Okay, I will wait for the next PR.
And I'm not going to leave maintenance to others at the moment.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants