Replaced *mut T by Option<NonNull<T>> in box.rs #1
Conversation
|
@danielhenrymantilla thank you for the PR! |
|
Since you were nowhere to be seen I was on standby ^^' There it is |
src/boxed.rs
Outdated
| }) | ||
| BoxAllocation( | ||
| ptr::NonNull::new(unsafe { alloc::alloc(layout) as *mut T }) | ||
| .unwrap_or_else(|| std::process::abort()) // abort on oom |
There was a problem hiding this comment.
how is this different from just unwrap()?
There was a problem hiding this comment.
Hmm, for a long time Rust strtegy on oom was to abort (since a panic! unwinds the stack, running destructors, which may allocate memory), but now that you point it out, more "recent" threads such as rust-lang/rust#43596 seem to point in the opposite direction. I will investigate further to see if replacing it with .unwrap() is now the preferred approach.
|
What’s the status on this? |
Normalised formatting on src/box.rs
|
bors r+ |
1: Replaced *mut T by Option<NonNull<T>> in box.rs r=kvark a=danielhenrymantilla Co-authored-by: danielhenrymantilla <[email protected]>
Build succeeded |
|
@danielhenrymantilla we just realized that this PR fixed an UB behavior on alloc() returning NULL. |
No description provided.